Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(http): remove CookieMap #4179

Merged
merged 1 commit into from Jan 14, 2024
Merged

BREAKING(http): remove CookieMap #4179

merged 1 commit into from Jan 14, 2024

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented Jan 12, 2024

Closes #3942
Related #3655

@iuioiua iuioiua requested a review from kt3k as a code owner January 12, 2024 21:06
@github-actions github-actions bot added the http label Jan 12, 2024
@iuioiua iuioiua enabled auto-merge (squash) January 13, 2024 06:12
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit 5d66bdf into main Jan 14, 2024
12 checks passed
@iuioiua iuioiua deleted the remove-cookie-map branch January 14, 2024 10:55
@joehillen
Copy link
Contributor

Why do y'all keep removing stuff without any justification or documentation?

@crowlKats
Copy link
Member

@joehillen this was marked deprecated for multiple releases with notes on replacement (being https://deno.land/std/http/cookie.ts), and then was removed.

@joehillen
Copy link
Contributor

Links to a GitHub issue for the discussion or justification in the release notes, PR, commit message, or deprecation notice would be appreciated.

@joehillen
Copy link
Contributor

And I'm not just referring to this specific issue. There is a general lack of transparency in this project.

@iuioiua
Copy link
Collaborator Author

iuioiua commented Jan 28, 2024

Hey @joehillen, we don't remove anything without any justification or documentation. In this case, I mistakenly didn't link to the corresponding issues concerning the rationale for the deprecation. My bad. I've now fixed the initial comment of this PR.

Regarding documentation, as Leo said, we mark the APIs as deprecated for multiple versions. However, from now on, we should open a GitHub issue for the lifetime of an API's deprecation. That issue should then be linked to within the deprecation notice. The issue would only be closed if the consensus remains in support of the deprecation. WDYT, @kt3k? If you agree, we can work to upgrade the current deprecation notices in the codebase.

A general lack of transparency is the opposite of what we aim for in this project. If there are any other holes like this, please let us know.

@kt3k
Copy link
Member

kt3k commented Jan 28, 2024

However, from now on, we should open a GitHub issue for the lifetime of an API's deprecation. That issue should then be linked to within the deprecation notice. The issue would only be closed if the consensus remains in support of the deprecation.

That sounds a good idea 👍 Let's do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proposal: deprecate std/http/cookie_map
4 participants