-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING(http): remove CookieMap
#4179
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Why do y'all keep removing stuff without any justification or documentation? |
@joehillen this was marked deprecated for multiple releases with notes on replacement (being https://deno.land/std/http/cookie.ts), and then was removed. |
Links to a GitHub issue for the discussion or justification in the release notes, PR, commit message, or deprecation notice would be appreciated. |
And I'm not just referring to this specific issue. There is a general lack of transparency in this project. |
Hey @joehillen, we don't remove anything without any justification or documentation. In this case, I mistakenly didn't link to the corresponding issues concerning the rationale for the deprecation. My bad. I've now fixed the initial comment of this PR. Regarding documentation, as Leo said, we mark the APIs as deprecated for multiple versions. However, from now on, we should open a GitHub issue for the lifetime of an API's deprecation. That issue should then be linked to within the deprecation notice. The issue would only be closed if the consensus remains in support of the deprecation. WDYT, @kt3k? If you agree, we can work to upgrade the current deprecation notices in the codebase. A general lack of transparency is the opposite of what we aim for in this project. If there are any other holes like this, please let us know. |
That sounds a good idea 👍 Let's do it |
Closes #3942
Related #3655