feat: print warning on use of deprecated API #4200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iuioiua
changed the title
warnDeprecatedApi()
|
I think this tool is good enough for first pass. |
iuioiua
commented
Jan 17, 2024
deno.json
Outdated
| @@ -12,7 +12,7 @@ | |||
| "automation/": "https://raw.githubusercontent.com/denoland/automation/0.10.0/" | |||
| }, | |||
| "tasks": { | |||
| "test": "deno test --doc --unstable --allow-all --parallel --coverage --trace-ops", | |||
| "test": "NO_DEPRECATION_WARNINGS=1 deno test --doc --unstable --allow-all --parallel --coverage --trace-ops", | |||
There was a problem hiding this comment.
This is needed for cases where we must still continue to test deprecated APIs.
internal/mod.ts
Outdated
There was a problem hiding this comment.
Does having an internal folder interfere with workspaces functionality, @lucacasonato?
kt3k
reviewed
Jan 17, 2024
How can we make internal tools and workspaces work? What are some options? |
kt3k
reviewed
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function prints a friendly warning if the given deprecated API is being used. This implementation is based on denoland/deno#21939, but with a few differences that make more sense for the Standard Library.