Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(io): un-deprecate readerFromStreamReader() #4343

Merged
merged 2 commits into from Feb 19, 2024
Merged

feat(io): un-deprecate readerFromStreamReader() #4343

merged 2 commits into from Feb 19, 2024

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented Feb 16, 2024

This change un-deprecates readerFromStreamReader() and moves it from std/streams to std/io.

Closes #4336

@iuioiua iuioiua mentioned this pull request Feb 16, 2024
Closed
@andrewthauer
Copy link
Contributor

@kt3k - Added some discussion / curiosity in general around the Streams API vs Deno Reader/Writer compatibility in #4336. Wondering if you might have some insights here?

@iuioiua iuioiua requested a review from kt3k February 18, 2024 20:57
kt3k
kt3k approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@iuioiua
Copy link
Collaborator Author

iuioiua commented Feb 19, 2024

Merging as I received support for this un-deprecation from @crowlKats offline.

@iuioiua iuioiua merged commit 253e329 into main Feb 19, 2024
10 checks passed
@iuioiua iuioiua deleted the undeprecate-readerFromStreamReader branch February 19, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewthauer andrewthauer andrewthauer left review comments

@kt3k kt3k kt3k approved these changes

@crowlKats crowlKats Awaiting requested review from crowlKats crowlKats is a code owner

Assignees
No one assigned
Labels
io streams
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecation of readerFromStreamReader seems to have no direct replacement from Readable to Reader
3 participants
@iuioiua @andrewthauer @kt3k