refactor(log): Deprecate BaseHandler.setup() and BaseHandler.destroy()
#4435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timreichen
changed the title
BaseHandler.setup() and BaseHandler.destroy()
iuioiua
requested changes
Mar 5, 2024
| @@ -100,11 +114,4 @@ export class FileHandler extends BaseHandler { | |||
| #resetBuffer() { | |||
| this._pointer = 0; | |||
| } | |||
|
|
|||
| override destroy() { | |||
There was a problem hiding this comment.
This method should have a deprecation notice. Otherwise, this is a breaking change. We can also just call .close() within it now.
| } | ||
|
|
||
| override setup() { | ||
| open() { | ||
| if (this.#isOpen) return; |
There was a problem hiding this comment.
This isn't relevant to this PR. I might argue it's unnecessary, as we have the open/close status of this._file we can use instead.
There was a problem hiding this comment.
Can you please revert these changes? This ensures the legacy and possible new methods all work.
There was a problem hiding this comment.
Ditto. Can you please revert these changes?
iuioiua
requested changes
Mar 5, 2024
|
@timreichen, I'm going to close this PR for now. I think we need to discuss and consider this more before proceeding. Either way, thanks for trying to push this forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #4391
Changes
BaseHandler.setup()BaseHandler.destroy()FileHandler.open()to replaceFileHandler.setup()FileHandler.close()to replaceFileHandler.destroy()setup()function work withoutBaseHandler.setup()andBaseHandler.destroy()