Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(yaml): speciously restrictive type for stringify() #4507

Merged
merged 2 commits into from Mar 23, 2024

Conversation

hudlow
Copy link
Contributor

@hudlow hudlow commented Mar 20, 2024

Fixes #4506.

@hudlow hudlow requested a review from kt3k as a code owner March 20, 2024 11:14
@CLAassistant
Copy link

CLAassistant commented Mar 20, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the yaml label Mar 20, 2024
@kt3k
Copy link
Member

kt3k commented Mar 20, 2024

Thanks for the PR. This change looks reasonable to me.

Can you also update the object phrase in jsdoc to data?

(Note: This seems to have been introduced as a part of large TS upgrade PR long time ago denoland/deno#6514. I don't think this is intentionally in this way)

@hudlow
Copy link
Contributor Author

hudlow commented Mar 20, 2024

Done.

Copy link
Collaborator

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua changed the title fix(yaml): speciously restrictive type for stringify() fix(yaml): speciously restrictive type for stringify() Mar 23, 2024
@iuioiua iuioiua merged commit 6be1650 into denoland:main Mar 23, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

YAML stringify() speciously restricts input type to Record<string, unknown>
4 participants