[unstable] BREAKING(semver): remove comparator.semver field #4533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iuioiua
approved these changes
Mar 28, 2024
semver/test_range.ts
Outdated
Comment on lines
55
to
57
| const major = comparator.major; | ||
| const minor = comparator.minor; | ||
| const patch = comparator.patch; |
There was a problem hiding this comment.
Nit: maybe destructure with const { prerelease } = comparator; above?
|
Also, can you please include context and background in the initial comment so users can trace? |
iuioiua
approved these changes
Mar 28, 2024
eryue0220
added a commit
to eryue0220/deno_std
that referenced
this pull request
Mar 30, 2024
…220/deno_std into feat/expect-addSnapshotSerializer * 'feat/expect-addSnapshotSerializer' of github.com:eryue0220/deno_std: deprecation(crypto): rename an export to match style guide, deprecating original and two other obsolete imports (denoland#4525) chore: add `--allow-dirty` flag to publish dry run (denoland#4535) [unstable] BREAKING(semver): remove comparator.semver field (denoland#4533) chore(crypto): upgrade dependencies (denoland#4530) 0.221.0 (denoland#4531) docs(fs): polish documentation (denoland#4526) fix(fs): `SubdirectoryMoveError` extends `Error` correctly (denoland#4528) chore(fs): remove `test.ts` (denoland#4527)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided to migrate
Comparatortype from:To:
as part of #4161. This reduces the nesting structure of
Rangetype one level.Currently we have the below comparator type for supporting both types in transition period:
This PR removes
semver?field from the existing Comparator type to end the support of the old Comparator type.