Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable Codecov comments in PRs #4579

Merged
merged 1 commit into from
Apr 12, 2024
Merged

chore: enable Codecov comments in PRs #4579

merged 1 commit into from
Apr 12, 2024

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented Apr 12, 2024

This change enables Codecov comments. I find myself having to manually look up test coverage changes on commits in the Codecov UI. Having this presented within PR feeds would help a lot. We can re-evaluate if it becomes too noisy.

@iuioiua iuioiua requested a review from kt3k as a code owner April 12, 2024 06:20
@@ -9,5 +8,3 @@ coverage:
patch:
default:
informational: true
ignore:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pass-by cleanup. std/examples no longer exists.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit aac6829 into main Apr 12, 2024
11 checks passed
@iuioiua iuioiua deleted the update-codecov branch April 12, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants