Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[encoding] add csv parse #458

Merged
merged 11 commits into from May 30, 2019
Merged

[encoding] add csv parse #458

merged 11 commits into from May 30, 2019

Conversation

zekth
Copy link
Contributor

@zekth zekth commented May 27, 2019

Ported https://github.com/zekth/deno_easyCSV to encoding/csv.
Also added the possibility to use BufReader as input and not only string.

ref: #455

@ry
Copy link
Member

ry commented May 27, 2019

Cool - looks good - but I'm holding for #444.

ry
ry reviewed May 27, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update encoding/README.md too?

@zekth
Copy link
Contributor Author

zekth commented May 30, 2019

Rebased.
Passes tests but still have the uTime problem on the MacOs ci

@ry
Copy link
Member

ry commented May 30, 2019

uTime problem on the MacOs ci

What's that? Can you submit a PR to disable it until we have a fix?

@zekth
Copy link
Contributor Author

zekth commented May 30, 2019

uTime problem on the MacOs ci

What's that? Can you submit a PR to disable it until we have a fix?

here are the related issues:
denoland/deno#2411
#421

i'll disable the test so.

ry
ry reviewed May 30, 2019
View reviewed changes
fs/copy_test.ts Outdated Show resolved Hide resolved
ry
ry approved these changes May 30, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit 167f529 into denoland:master May 30, 2019
@zekth zekth deleted the add_csv_parse branch May 30, 2019 13:52
@bartlomieju bartlomieju mentioned this pull request Jun 15, 2019
Closed
ry pushed a commit to ry/deno that referenced this pull request Oct 9, 2019
@zekth @ry
encoding: add csv parse (denoland/deno_std#458)
2487c45 
Original: denoland/deno_std@167f529
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zekth @ry