Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(csv): do not print empty header line when no columns are given in stringify() #4610

Merged
merged 1 commit into from Apr 22, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Apr 19, 2024

closes #4546

@github-actions github-actions bot added the csv label Apr 19, 2024
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.98%. Comparing base (a6fe34b) to head (e0b0df6).
Report is 222 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4610      +/-   ##
==========================================
- Coverage   91.23%   90.98%   -0.26%     
==========================================
  Files         478      475       -3     
  Lines       41465    37307    -4158     
  Branches     5225     5299      +74     
==========================================
- Hits        37832    33942    -3890     
+ Misses       3568     3311     -257     
+ Partials       65       54      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua changed the title fix(csv): do not print empty header line when no columns are given fix(csv): do not print empty header line when no columns are given in stringify() Apr 20, 2024
@kt3k kt3k merged commit c93b8a6 into denoland:main Apr 22, 2024
14 checks passed
@kt3k kt3k deleted the no-header-when-no-columns branch April 22, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

csv - stringify with no options should not output an empty blank line before the data
2 participants