Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(assert): improve test coverage #4679

Merged
merged 5 commits into from May 7, 2024
Merged

Conversation

mbhrznr
Copy link
Contributor

@mbhrznr mbhrznr commented May 6, 2024

working towards #3713.
pushes code coverage of the assert sub-module to 100%.

primarily some smaller missing tests, such as the often optional msg arg and/or testing for invalid input.
slightly tweaks some smaller implementation details, where the code was unreachable during testing.

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.47%. Comparing base (5e99c21) to head (606146c).

❗ Current head 606146c differs from pull request most recent head a847a85. Consider uploading reports for the commit a847a85 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4679      +/-   ##
==========================================
+ Coverage   91.36%   91.47%   +0.11%     
==========================================
  Files         477      477              
  Lines       37332    37330       -2     
  Branches     5323     5328       +5     
==========================================
+ Hits        34107    34149      +42     
+ Misses       3164     3125      -39     
+ Partials       61       56       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! Thank you.

assert/assert_instance_of_test.ts Show resolved Hide resolved
@iuioiua iuioiua enabled auto-merge (squash) May 7, 2024 00:06
@iuioiua iuioiua merged commit b649680 into denoland:main May 7, 2024
10 checks passed
@mbhrznr
Copy link
Contributor Author

mbhrznr commented May 7, 2024

thanks for the clean up! 🙏

@mbhrznr mbhrznr deleted the test/assert branch May 7, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants