Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(collections): correct error class when chunk() throws #4682

Merged
merged 1 commit into from May 7, 2024
Merged

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented May 7, 2024

This is a more fitting error class for when size is incorrectly defined.

@iuioiua iuioiua requested a review from kt3k as a code owner May 7, 2024 03:27
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.47%. Comparing base (b649680) to head (865a9b5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4682   +/-   ##
=======================================
  Coverage   91.47%   91.47%           
=======================================
  Files         477      477           
  Lines       37330    37330           
  Branches     5328     5328           
=======================================
  Hits        34149    34149           
  Misses       3125     3125           
  Partials       56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'd rather tag this fix as this includes a user-visible change

@kt3k kt3k changed the title refactor(collections): correct error class when chunk() throws fix(collections): correct error class when chunk() throws May 7, 2024
@iuioiua iuioiua merged commit e7b2ca6 into main May 7, 2024
13 checks passed
@iuioiua iuioiua deleted the chunk-error branch May 7, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants