Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(internal): cleanup and restructure #4698

Merged
merged 9 commits into from
May 9, 2024
Merged

refactor(internal): cleanup and restructure #4698

merged 9 commits into from
May 9, 2024

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented May 9, 2024

This change simplifies the DiffType and moves functions out into their own respective files with the aim of improving maintainability, as internal/diff.ts is quite a busy file. Further improvements should come after this PR.

@iuioiua iuioiua requested a review from kt3k as a code owner May 9, 2024 00:43
Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 93.56725% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 91.47%. Comparing base (883f129) to head (1d7bc24).
Report is 1 commits behind head on main.

Files Patch % Lines
internal/diff_str.ts 92.59% 8 Missing ⚠️
internal/build_message.ts 94.11% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4698      +/-   ##
==========================================
- Coverage   91.47%   91.47%   -0.01%     
==========================================
  Files         477      479       +2     
  Lines       37318    37315       -3     
  Branches     5325     5325              
==========================================
- Hits        34137    34134       -3     
  Misses       3125     3125              
  Partials       56       56              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua marked this pull request as draft May 9, 2024 00:59
@iuioiua iuioiua changed the title refactor(internal): cleanup refactor(internal): cleanup and restructure May 9, 2024
@iuioiua iuioiua marked this pull request as ready for review May 9, 2024 02:47
internal/diff_str.ts Outdated Show resolved Hide resolved
@iuioiua iuioiua requested a review from kt3k May 9, 2024 05:19
@iuioiua iuioiua enabled auto-merge (squash) May 9, 2024 05:20
internal/deno.json Outdated Show resolved Hide resolved
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit a63a439 into main May 9, 2024
12 checks passed
@iuioiua iuioiua deleted the internal-cleanup branch May 9, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants