-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(internal): cleanup and restructure #4698
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4698 +/- ##
==========================================
- Coverage 91.47% 91.47% -0.01%
==========================================
Files 477 479 +2
Lines 37318 37315 -3
Branches 5325 5325
==========================================
- Hits 34137 34134 -3
Misses 3125 3125
Partials 56 56 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This change simplifies the
DiffType
and moves functions out into their own respective files with the aim of improving maintainability, asinternal/diff.ts
is quite a busy file. Further improvements should come after this PR.