-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(assert): vendor code from fmt/colors.ts
#4716
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4716 +/- ##
==========================================
- Coverage 91.44% 91.44% -0.01%
==========================================
Files 480 481 +1
Lines 37318 37371 +53
Branches 5316 5318 +2
==========================================
+ Hits 34126 34173 +47
- Misses 3136 3142 +6
Partials 56 56 ☔ View full report in Codecov by Sentry. |
Frankly, I'd prefer we minimize our use of colors as much as possible. |
Maybe this only makes sense when we reached a consensus on #4676 |
How does that issue affect this PR? |
If we don't move |
Then stabilizing |
Ok. Makes sense |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Towards #4717