Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(assert): vendor code from fmt/colors.ts #4716

Merged
merged 5 commits into from
May 15, 2024
Merged

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented May 13, 2024

Towards #4717

Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 91.44%. Comparing base (4398642) to head (a26dbe3).

Files Patch % Lines
internal/styles.ts 88.67% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4716      +/-   ##
==========================================
- Coverage   91.44%   91.44%   -0.01%     
==========================================
  Files         480      481       +1     
  Lines       37318    37371      +53     
  Branches     5316     5318       +2     
==========================================
+ Hits        34126    34173      +47     
- Misses       3136     3142       +6     
  Partials       56       56              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua mentioned this pull request May 13, 2024
9 tasks
@iuioiua iuioiua marked this pull request as ready for review May 13, 2024 07:28
@iuioiua iuioiua requested a review from kt3k as a code owner May 13, 2024 07:28
@iuioiua
Copy link
Collaborator Author

iuioiua commented May 13, 2024

Frankly, I'd prefer we minimize our use of colors as much as possible.

@kt3k
Copy link
Member

kt3k commented May 14, 2024

Maybe this only makes sense when we reached a consensus on #4676

@iuioiua
Copy link
Collaborator Author

iuioiua commented May 14, 2024

How does that issue affect this PR?

@kt3k
Copy link
Member

kt3k commented May 14, 2024

If we don't move fmt/colors (and stabilize it as is), then we don't need to do this

@iuioiua
Copy link
Collaborator Author

iuioiua commented May 14, 2024

Then stabilizing std/fmt would block the stabilization of std/internal and std/assert, and stabilizing std/fmt is not yet on the radar. This PR allows us to make these moves asynchronously. I think we should proceed with this PR, even if we change things later.

@kt3k
Copy link
Member

kt3k commented May 15, 2024

Ok. Makes sense

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit 0c44d96 into main May 15, 2024
12 checks passed
@iuioiua iuioiua deleted the vendor-color-assert branch May 15, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants