docs(assert): document assertStrictEquals() equality comparison behavior
#4724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iuioiua
changed the title
assertStrictEquals() equality comparison behaviorassertStrictEquals() equality comparison behavior
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4724 +/- ##
=======================================
Coverage 91.44% 91.44%
=======================================
Files 480 480
Lines 37318 37318
Branches 5316 5316
=======================================
Hits 34126 34126
Misses 3136 3136
Partials 56 56 ☔ View full report in Codecov by Sentry. |
kt3k
reviewed
May 14, 2024
assert/assert_strict_equals.ts
Outdated
Comment on lines
11
to
12
| * This function copies the behavior of Node's | ||
| * {@linkcode https://nodejs.org/api/assert.html#assertstrictequalactual-expected-message | assert.strictStrictEqual}, |
There was a problem hiding this comment.
We also consider the compatibility to jest, vitest, etc. I don't think we need to mention this information (internal design decision details) here
kt3k
reviewed
May 14, 2024
assert/assert_strict_equals.ts
Outdated
| @@ -8,6 +8,12 @@ import { red } from "@std/fmt/colors"; | |||
| * Make an assertion that `actual` and `expected` are strictly equal. If | |||
There was a problem hiding this comment.
Make an assertion that actual and expected are strictly equal
I think this part needs to be updated as it's not technically 'strict equality'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4714