docs(media-types): polish documentation #4731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iuioiua
commented
May 15, 2024
| * getCharset("application/foo"); // undefined | ||
| * getCharset("application/news-checkgroups"); // "US-ASCII" | ||
| * getCharset("application/news-checkgroups; charset=UTF-8"); // "UTF-8" | ||
| * assertEquals(getCharset("text/plain"), "UTF-8"); |
There was a problem hiding this comment.
Honestly, I wonder whether having assertions within examples is the best solution for what examples aim to achieve. The pro is that it guarantees that examples are correct. The cons are a slight reduction in readability and an extra dependency. I'm happy to hear other's thoughts.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4731 +/- ##
==========================================
+ Coverage 91.44% 91.88% +0.43%
==========================================
Files 480 482 +2
Lines 37318 41211 +3893
Branches 5316 5316
==========================================
+ Hits 34126 37865 +3739
- Misses 3136 3289 +153
- Partials 56 57 +1 ☔ View full report in Codecov by Sentry. |
kt3k
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #4730