Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(encoding): adds streaming versions for hex, base32, base64 and base64url #4915

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

BlackAsLight
Copy link
Contributor

Jumping from #4756, closing #3087

Essentially merging @doctor/encoding-stream into @std/encoding.

Adds streaming methods for:
- Hex
- Base32
- Base64
- Base64Url
Copy link
Collaborator

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tidily done so far! Can you please add these modules to new <encoding>-stream exports? E.g., @std/encoding/hex-stream. The reasoning is mostly for greater visibility.

@BlackAsLight
Copy link
Contributor Author

Tidily done so far! Can you please add these modules to new <encoding>-stream exports? E.g., @std/encoding/hex-stream. The reasoning is mostly for greater visibility.

I definitely can but it looked like here #4756 (comment) that you'd agreed it should be in the same module.

@iuioiua
Copy link
Collaborator

iuioiua commented Jun 6, 2024

Ah, to clarify, I meant within the @std/encoding package. Sorry for the confusion.

@BlackAsLight
Copy link
Contributor Author

I pulled them out into their own module, but it does seem a bit harder to maintain since so many of the files start with the same name base64

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 93.84615% with 12 lines in your changes missing coverage. Please review.

Project coverage is 92.45%. Comparing base (41a2da4) to head (72b7a63).
Report is 1 commits behind head on main.

Files Patch % Lines
encoding/hex_stream.ts 84.21% 6 Missing ⚠️
encoding/base32_stream.ts 94.00% 3 Missing ⚠️
encoding/base64_stream.ts 94.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #4915    +/-   ##
========================================
  Coverage   92.44%   92.45%            
========================================
  Files         481      485     +4     
  Lines       38732    38927   +195     
  Branches     5446     5469    +23     
========================================
+ Hits        35806    35989   +183     
- Misses       2871     2883    +12     
  Partials       55       55            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k kt3k added the after 1.0 label Jun 6, 2024
@iuioiua
Copy link
Collaborator

iuioiua commented Jun 19, 2024

FYI @BlackAsLight, in case you're unaware, we haven't forgotten about this PR. We will take a closer look once @std/encoding@1.0.0 is released.

@BlackAsLight
Copy link
Contributor Author

I assumed as much, I think it might be good to wait until after #4931 is merged in as well though so I can then also add a Base32HexStream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants