-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(encoding): adds streaming versions for hex, base32, base64 and base64url #4915
base: main
Are you sure you want to change the base?
Conversation
Adds streaming methods for: - Hex - Base32 - Base64 - Base64Url
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tidily done so far! Can you please add these modules to new <encoding>-stream
exports? E.g., @std/encoding/hex-stream
. The reasoning is mostly for greater visibility.
I definitely can but it looked like here #4756 (comment) that you'd agreed it should be in the same module. |
Ah, to clarify, I meant within the |
I pulled them out into their own module, but it does seem a bit harder to maintain since so many of the files start with the same name |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4915 +/- ##
========================================
Coverage 92.44% 92.45%
========================================
Files 481 485 +4
Lines 38732 38927 +195
Branches 5446 5469 +23
========================================
+ Hits 35806 35989 +183
- Misses 2871 2883 +12
Partials 55 55 ☔ View full report in Codecov by Sentry. |
FYI @BlackAsLight, in case you're unaware, we haven't forgotten about this PR. We will take a closer look once |
I assumed as much, I think it might be good to wait until after #4931 is merged in as well though so I can then also add a |
Jumping from #4756, closing #3087
Essentially merging
@doctor/encoding-stream
into@std/encoding
.