Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove --table functionality from graph checker #5064

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented Jun 17, 2024

This functionality is no longer used and won't be needed after jsr-io/jsr#528 is merged.

@iuioiua iuioiua requested a review from kt3k as a code owner June 17, 2024 20:53
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.32%. Comparing base (4ba4bee) to head (10214f5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5064   +/-   ##
=======================================
  Coverage   92.32%   92.32%           
=======================================
  Files         481      481           
  Lines       38752    38752           
  Branches     5444     5444           
=======================================
  Hits        35776    35776           
  Misses       2921     2921           
  Partials       55       55           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit d93aa7c into main Jun 18, 2024
12 checks passed
@iuioiua iuioiua deleted the remove-table-graph branch June 18, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants