Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(internal): assertStrictThrows() and assertStrictRejects() #5073

Closed
wants to merge 2 commits into from

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented Jun 18, 2024

Once merged, we can track the updating of tests to use these new functions.

Closes #5072

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 96.92308% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.41%. Comparing base (6997e8b) to head (300a20c).

Files Patch % Lines
internal/assert_strict.ts 96.87% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5073   +/-   ##
=======================================
  Coverage   92.40%   92.41%           
=======================================
  Files         481      482    +1     
  Lines       38747    38812   +65     
  Branches     5449     5455    +6     
=======================================
+ Hits        35806    35869   +63     
- Misses       2886     2888    +2     
  Partials       55       55           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua
Copy link
Collaborator Author

iuioiua commented Jun 19, 2024

Closing. See #5072 (comment).

@iuioiua iuioiua closed this Jun 19, 2024
@iuioiua iuioiua deleted the assert-strict branch June 19, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

suggestion: internal assertStrictThrows() and assertStrictRejects()
1 participant