fix: add global test registry #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ry
reviewed
Aug 18, 2019
bartlomieju
changed the title
|
@ry do you want me to change anything else in this PR? |
ry
reviewed
Aug 21, 2019
| @@ -69,8 +69,29 @@ function print(txt: string, newline: boolean = true): void { | |||
| Deno.stdout.writeSync(encoder.encode(`${txt}`)); | |||
| } | |||
|
|
|||
| declare global { | |||
| interface Window { | |||
There was a problem hiding this comment.
Is it really necessary to declare this before hand?
There was a problem hiding this comment.
Without it TS complains that __DENO_TEST_REGISTRY doesn't exist on Window:
error TS2339: Property '__DENO_TEST_REGISTRY' does not exist on type 'Window'.
► file:///Users/biwanczuk/dev/deno_std/testing/mod.ts:90:23
90 candidates = window.__DENO_TEST_REGISTRY as TestDefinition[];
I can add @ts-ignore but this solution is more idiomatic
This was referenced Aug 21, 2019
ry
pushed a commit
to ry/deno
that referenced
this pull request
Oct 9, 2019
After adding deno test command a new problem appeared. If you try running deno test inside this repo test runner will find 80 test files but won't run any tests! This is caused by fact that deno test uses tagged version of standard library which causes test function available inside to repo to be different function that test available in standard lib used by deno test. Original: denoland/deno_std@4531fa8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After adding
deno testcommand a new problem appeared.If you try running
deno testinside this repo test runner will find 80 test files but won't run any tests! This is caused by fact thatdeno testuses tagged version of standard library which causestestfunction available inside to repo to be different function thattestavailable in standard lib used bydeno test.A simple fix appears to be to add a global registry of all tests. It causes to register every test (even using
testfunction from different version of standard lib) in the same global array that can be picked up by test runner.That's just first iteration and we'll probably arrive at better solution before landing this PR.
CC @ry