Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(http/cookie): remove Cookies and SameSite type aliases #720

Conversation

caspervonb
Copy link
Contributor

No description provided.

@caspervonb caspervonb force-pushed the breaking-http-cookie-remove-cookies-type-alias branch from c5c381d to e12310d Compare February 11, 2021 12:18
@bartlomieju
Copy link
Member

Can you remove SameSite type as well?

@caspervonb caspervonb force-pushed the breaking-http-cookie-remove-cookies-type-alias branch from e12310d to a33ebd2 Compare February 11, 2021 12:32
@caspervonb caspervonb force-pushed the breaking-http-cookie-remove-cookies-type-alias branch from a33ebd2 to ab82975 Compare February 11, 2021 12:37
@caspervonb caspervonb changed the title breaking(http/cookie): remove cookies type alias BREAKING(http/cookie): remove Cookies and SameSite type aliases Feb 11, 2021
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 07050a8 into denoland:main Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants