Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(multipart): support useDefineForClassFields #807

Merged
merged 1 commit into from
Mar 15, 2021
Merged

fix(multipart): support useDefineForClassFields #807

merged 1 commit into from
Mar 15, 2021

Conversation

lucacasonato
Copy link
Member

@lucacasonato lucacasonato commented Mar 15, 2021 •
edited
Loading

Broke as a result of denoland/deno@c470983.

@lucacasonato
fix(multipart): support useDefineForClassFields
36c511d 
Fixes CI. Broke as a result of c4709834b37640fd3c9d492123e6add904546573.
ry
ry approved these changes Mar 15, 2021
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tho the extra boilerplate is rather unfortunate.

@lucacasonato lucacasonato merged commit 1362106 into denoland:main Mar 15, 2021
@lucacasonato lucacasonato deleted the fix_multipart branch March 15, 2021 12:31
@nayeemrmn nayeemrmn mentioned this pull request Mar 15, 2021
Closed
@lucacasonato lucacasonato mentioned this pull request Apr 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucacasonato @ry