fix(http,ws): conn typings on internal utils #861
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the return type from `Deno.Conn` to `Deno.Conn<Deno.NetAddr>` on two of the internal functions used to mock conn objects. The issue was introduced in core at `9c7c9a35`. In the case of `http/_mock_conn.ts@mockConn` I also had to add an explicit type hint on the return object because of the `base` parameter that was causing the type checker to not like the `transport` property on `localAddr` and `remoteAddr`.
lucacasonato
requested changes
Apr 19, 2021
There was a problem hiding this comment.
I don't want to land this. This being broken points to the upstream patch in CLI to be majorly breaking. It will break all old std versions. It should be reverted. cc @kitsonk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the return type from
Deno.ConntoDeno.Conn<Deno.NetAddr>ontwo of the internal functions used to mock conn objects. The issue was
introduced in core at
9c7c9a35.In the case of
http/_mock_conn.ts@mockConnI also had to add anexplicit type hint on the return object because of the
baseparameterthat was causing the type checker to not like the
transportpropertyon
localAddrandremoteAddr.