Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node/assert): Enable test-assert-fail.js and align fail to it #874

Merged
merged 3 commits into from
Apr 28, 2021
Merged

fix(node/assert): Enable test-assert-fail.js and align fail to it #874

merged 3 commits into from
Apr 28, 2021

Conversation

uki00a
Copy link
Contributor

@uki00a uki00a commented Apr 24, 2021

While working on #872, I noticed that assert.fail is not implemented properly. So this PR implements assert.fail so that it passes test-assert-fail.js.

@uki00a
Copy link
Contributor Author

uki00a commented Apr 25, 2021

Blocked by #879 🙂

kt3k
kt3k approved these changes Apr 27, 2021
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uki00a Thanks! LGTM.

@kt3k kt3k merged commit 2be830a into denoland:main Apr 28, 2021
@uki00a uki00a deleted the fix-assert-fail branch April 28, 2021 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@uki00a @kt3k