chore: add underscore prefix to unused variables #940
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current published version of deno_lint doesn't claim, but the next version is going to check if variables declared in
for-of
andfor-in
are used or not.denoland/deno_lint#697
So I added underscore prefix to such variables, in order to tell the linter that it's intentional to declare unused ones.
As a side note: we should remove ESLint disable directives because the linter doesn't support them since denoland/deno#8226.
I'm working on this.Done in #941