Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(encoding/toml): fix bad string format. Improve coverage #991

Merged
merged 3 commits into from
Jun 30, 2021
Merged

feat(encoding/toml): fix bad string format. Improve coverage #991

merged 3 commits into from
Jun 30, 2021

Conversation

zekth
Copy link
Contributor

@zekth zekth commented Jun 30, 2021 •
edited
Loading

  • feat: delete unecessary strip comment
  • feat: fix bad string format

This PR fixes a bad string format case and improve the code coverage of the module.

https://github.com/denoland/deno_std/pull/991/files#diff-19e328eb13386efb857272f7a07dc8e4af82f62848bb9abc6ab319110a3c626cL276-L281

This was deleted because it was the legacy strip of comments. The previous fixes make this useless.

@wperron wperron self-assigned this Jun 30, 2021
wperron
wperron approved these changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@wperron wperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- validated the new test cases locally, thanks for the contribution

@wperron wperron merged commit 3f3a1a7 into denoland:main Jun 30, 2021
@zekth zekth deleted the coverage_toml branch June 30, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wperron wperron wperron approved these changes

Assignees

@wperron wperron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zekth @wperron