Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose execute_with_pipes? #86

Closed
baszalmstra opened this issue Jul 3, 2023 · 3 comments · Fixed by #87 or prefix-dev/deno_task_shell#1
Closed

Expose execute_with_pipes? #86

baszalmstra opened this issue Jul 3, 2023 · 3 comments · Fixed by #87 or prefix-dev/deno_task_shell#1

Comments

@baszalmstra
Copy link

baszalmstra commented Jul 3, 2023

Im working on integrating deno_task_shell into pixi. Its perfect for our use case so Im very happy this crate exists.

However, we also want to be able to create tests (similar to the TestBuilder in this crate) where we can capture the output of a shell command that is run. I couldn't figure out a way to do this because most of the code is pub(crate).

Would it be an option to expose execute_with_pipes and the required types so that we can consume the output of shell commands? I'm happy to make a PR.

@bartlomieju
Copy link
Member

@baszalmstra sure, PRs are welcome!

@ruben-arts
Copy link
Contributor

He @dsherret could you try to rerun the release jobs?

@dsherret
Copy link
Member

@ruben-arts oh, sorry. There was a crates.io outage that day and I didn't notice it failed. Just re-ran it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants