feat: kv.watch support #26
Conversation
| let codec = LengthDelimitedCodec::builder() | ||
| .little_endian() | ||
| .length_field_length(4) | ||
| .max_frame_length(16 * 1048576) |
| yield outputs; | ||
|
|
||
| let futures = subscriptions.iter_mut().map(|subscription| { | ||
| Box::pin(subscription.wait_until_updated(current_versionstamp)) |
There was a problem hiding this comment.
Is the Box::pin for getting around borrow checker issues? Can it be moved to the outer scope?
| // The response to a watch request for a single key. | ||
| message WatchKeyOutput { | ||
| // Whether the value changed since the last watch delivery. | ||
| bool changed = 1; |
There was a problem hiding this comment.
How strict should changed be? Does it mean "something might have changed" or "something definitely changed"? Does it mean there must be visible versionstamp change in entry_if_changed, or just "something might have happened between"?
If a key changes from null -> something -> null but watch() only captured the two null states, should it deliver Unchanged or Changed with both entry_if_changed == null?
There was a problem hiding this comment.
Changed. The CLI with raw: false (default) will de-duplicate on versionstamp (so will not redeliver) for this null -> value -> null case.
|
Does the /watch endpoint return I'm only seeing: |
Fixed |
This commit adds support for the
Database::watchmethod in both SQLite and remote backends, and the/watchmethod in the KV Connect protocol.