Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make protoc dependency optional #72

Merged
merged 5 commits into from
Apr 27, 2024

Conversation

nathanwhit
Copy link
Member

This PR makes the dependency on prost-build (and therefore protoc) optional.

To do this, the rust source generated by protoc is copied in-tree, and the build script will only recompile .proto files if the build_protos feature is enabled.

This does introduce a potential point of confusion if the proto definitions are modified, but presumably these are rarely changed.

Copy link
Member

@losfair losfair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me - could you add a CI test that regenerates protoc output and verifies they are identical to the committed files?

@nathanwhit
Copy link
Member Author

Thanks, looks good to me - could you add a CI test that regenerates protoc output and verifies they are identical to the committed files?

Added!

@losfair losfair merged commit 7e6aa78 into denoland:main Apr 27, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants