Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create project if not found #192

Merged
merged 6 commits into from
Nov 16, 2023
Merged

Conversation

arnauorriols
Copy link
Member

@arnauorriols arnauorriols commented Nov 10, 2023

Screen.Recording.2023-11-10.at.11.17.28.mov

…rganizations

This is to cover the case where the project exist in another organization and the creation fails
Copy link
Contributor

@lucab lucab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@magurotuna magurotuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally I'm in favor of the idea of creating a new project if the specified one doesn't exist, but I guess there might be a case where the project name is just a typo, in which case it would be undesirable to create a new project automatically. So what about prompting a user like Project xxx not found. Do you want to create one? [y/N] to check if the user really wants it?

@arnauorriols
Copy link
Member Author

Generally I'm in favor of the idea of creating a new project if the specified one doesn't exist, but I guess there might be a case where the project name is just a typo, in which case it would be undesirable to create a new project automatically. So what about prompting a user like Project xxx not found. Do you want to create one? [y/N] to check if the user really wants it?

I prefer the optimistic approach, as the name of the project is fairly incosequential and easy to change. I'll add a line outputing the link to the project settings to help users in this regard.

@arnauorriols arnauorriols enabled auto-merge (squash) November 16, 2023 12:11
@arnauorriols arnauorriols merged commit 5ddf441 into main Nov 16, 2023
13 checks passed
@arnauorriols arnauorriols deleted the automatic-project-creation branch November 16, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants