Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: complete logic in getTopLevelAwait function #132

Merged
merged 2 commits into from
Feb 22, 2022

Conversation

ah-yu
Copy link
Contributor

@ah-yu ah-yu commented Feb 22, 2022

Currently dnt cannot detect TLA like

if (condition) {
  await test();
}
for await (const item of items){ }

@CLAassistant
Copy link

CLAassistant commented Feb 22, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I realized there were even more scenarios not working so I fixed those too.

@dsherret dsherret merged commit 709701b into denoland:main Feb 22, 2022
@ah-yu ah-yu deleted the fix-tla branch February 22, 2022 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants