Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add emitDecoratorMetadata compiler option #217

Merged
merged 4 commits into from
Sep 26, 2022

Conversation

Gaubee
Copy link
Contributor

@Gaubee Gaubee commented Sep 19, 2022

isolatedModules, experimentalDecorators, emitDecoratorMetadata

isolatedModules, experimentalDecorators, emitDecoratorMetadata
@CLAassistant
Copy link

CLAassistant commented Sep 19, 2022

CLA assistant check
All committers have signed the CLA.

@Gaubee
Copy link
Contributor Author

Gaubee commented Sep 19, 2022

😸

@dsherret dsherret changed the title feat: add more compilerOptions feat: add emitDecoratorMetadata compiler option Sep 26, 2022
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Gaubee! I wanted to merge this one in because I might do a release soon, so I updated this PR to make the emitDecoratorMetadata compiler option false by default and removed the isolatedModules and experimentalDecorators options because those are always true in Deno. What's the rationale behind adding these options? Do you need them?

@dsherret dsherret merged commit d228e33 into denoland:main Sep 26, 2022
@Gaubee
Copy link
Contributor Author

Gaubee commented Sep 27, 2022

Thanks @Gaubee! I wanted to merge this one in because I might do a release soon, so I updated this PR to make the emitDecoratorMetadata compiler option false by default and removed the isolatedModules and experimentalDecorators options because those are always true in Deno. What's the rationale behind adding these options? Do you need them?

experimentalDecorators of course, many project use typescript decorators.
but the proposal-decorators
is coming. so I think this is about to be an option rather than a fixed value.

by the way. I write my packages use deno as my toolchain for nodejs/web/deno, I couldn't find a better toolchain then this one.

@Gaubee
Copy link
Contributor Author

Gaubee commented Sep 27, 2022

Thanks @Gaubee! I wanted to merge this one in because I might do a release soon, so I updated this PR to make the emitDecoratorMetadata compiler option false by default and removed the isolatedModules and experimentalDecorators options because those are always true in Deno. What's the rationale behind adding these options? Do you need them?

isolatedModules chould references to const enum members, is an looser options.
we should open this options, should work~

@Gaubee
Copy link
Contributor Author

Gaubee commented Sep 27, 2022

#226 rebase and open again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants