Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: .npmignore test sourcemap files #271

Merged
merged 1 commit into from
May 8, 2023
Merged

fix: .npmignore test sourcemap files #271

merged 1 commit into from
May 8, 2023

Conversation

davecardwell
Copy link
Contributor

Setting compilerOptions.sourceMap to true results in *.map files being output for the test files (e.g., _dnt.test_shims.js.map).

This PR ensures the source map files are also added to .npmignore so they are not published to NPM.

@CLAassistant
Copy link

CLAassistant commented Apr 8, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

dsherret
dsherret approved these changes May 8, 2023
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@dsherret dsherret merged commit 3a40faf into denoland:main May 8, 2023
@davecardwell davecardwell deleted the npmignore-test-sourcemaps branch May 9, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davecardwell @CLAassistant @dsherret