Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace chalk dev dependency with picocolors #279

Merged
merged 2 commits into from
May 15, 2023
Merged

feat: replace chalk dev dependency with picocolors #279

merged 2 commits into from
May 15, 2023

Conversation

UrielCh
Copy link
Contributor

@UrielCh UrielCh commented May 5, 2023

Replace chalk@^4.1.2 by picocolors@^1.0.0

Why

  • chalk@^4.1.2 depends on ansi-styles and supports-color
  • chalk add lots of stuff for only 4 calls (green(text), red(text), gray(text), underline(text))
  • Because you using chalk@4 instead of chalk@5, I wont develop this point.
  • Stop contributing to the node_modules blackhole paradigm, my 2Tb SSH is almost full 馃槩
  • Reduce CO虏 Emition, save the 馃實.

Note:

  • I'm not affiliated with the picocolors project.
  • I would prefer to use picocolors@1.0.0 rather than picocolors@^1.0.0 but that is another discussion.
  • You can refer to the official readme that explains why picocolors would replace chalk@4, it's a bit different for chalk@5

@CLAassistant
Copy link

CLAassistant commented May 5, 2023

CLA assistant check
All committers have signed the CLA.

@UrielCh
Copy link
Contributor Author

UrielCh commented May 6, 2023

Waiting for the completion of #278

@UrielCh
Copy link
Contributor Author

UrielCh commented May 10, 2023

synced with #278

@UrielCh
Copy link
Contributor Author

UrielCh commented May 15, 2023

up

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@dsherret dsherret changed the title Replace chalk by picocolors feat: replace chalk with picocolors May 15, 2023
@dsherret dsherret changed the title feat: replace chalk with picocolors feat: replace chalk dev dependency with picocolors May 15, 2023
@dsherret dsherret merged commit 0d999fb into denoland:main May 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants