feat: display multiple symbol kinds as a single symbol #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visually looks great to me |
kt3k
reviewed
Nov 23, 2022
| category?: string; | ||
| jsDoc?: JsDoc | null; | ||
| } | ||
|
|
||
| export function categorize( |
There was a problem hiding this comment.
This looks highly complex now. Let's add some test cases later #51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes denoland/dotland#2483
Example previews:
library index: https://dotland-pcw2qz4nw9s0.deno.dev/api@v1.28.1
library sidepanel: https://dotland-pcw2qz4nw9s0.deno.dev/api@v1.28.1?s=FormData
module sidepanel: https://dotland-pcw2qz4nw9s0.deno.dev/x/zod@v3.18.0/mod.ts?s=ZodIssueCode
The only problem with this is that module index (https://dotland-pcw2qz4nw9s0.deno.dev/x/zod@v3.18.0/mod.ts) is sectioned by symbol kind, so it could be weird if we do this there.