Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

Fix header a11y #442

Merged
merged 1 commit into from May 14, 2020
Merged

Fix header a11y #442

merged 1 commit into from May 14, 2020

Conversation

leonardoelias
Copy link
Contributor

Never remove CSS outlines

The solution today in menu is remove focus outline in links. But this is cause a big problem on usability.

Style the element itself. You can remove the outline as long as you style the focused element differently (using a combination of color, background-color, border or text-decoration: underline for example). When using this approach, avoid using color alone as the only visual means of determining focus, as color blind people may not be able to distinguish the focus state from the inactive state.

https://a11yproject.com/posts/never-remove-css-outlines/
WICG/focus-visible#128

@vercel
Copy link

vercel bot commented May 14, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/denoland/deno-website2/a85v9ello
✅ Preview: https://deno-website2-git-fork-leonardoelias-a11y-header.denoland.now.sh

Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this one - I didn't pay attention again.

@lucacasonato lucacasonato merged commit 185dab1 into denoland:master May 14, 2020
@leonardoelias
Copy link
Contributor Author

I'm sorry @lucacasonato , I didn't want to be rude. you are doing an incredible job.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants