Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

feat: add dark mode #60

Merged
merged 3 commits into from
Oct 25, 2019
Merged

feat: add dark mode #60

merged 3 commits into from
Oct 25, 2019

Conversation

lucacasonato
Copy link
Member

I have re-added dark mode. It gets enabled automatically by the media query prefers-color-scheme: dark. It was relatively easy to add after moving all tags to tags from material-ui. Now material styling also gets applied to links.

The only CSS I added was to invert the logo. Both the code blocks and the graphs have built in dark modes, so those were relatively easy - they get triggered by prefers-color-scheme: dark too.

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit f3b19cd into denoland:master Oct 25, 2019
@ry
Copy link
Member

ry commented Oct 25, 2019

Not sure what happened but I think this commit broke the links in https://deno.land/std/

@lucacasonato
Copy link
Member Author

@ry It did. I'll submit a fix in a second.

@bartlomieju
Copy link
Member

It's cool that dark mode is back but I liked the old one much better. White text on black background is really tiring for eyes. Any chance we could change background color to something more toned down? Even using color from charts for background color looks better IMHO

Zrzut ekranu 2019-10-25 o 22 45 30

Zrzut ekranu 2019-10-25 o 22 44 48

@lucacasonato lucacasonato deleted the dark-mode branch October 26, 2019 21:17
@vladimyr
Copy link

vladimyr commented Dec 4, 2019

I second what @bartlomieju already said plus color contrast of syntax highlighting is really low. That is why I tried to switch to dark mode and how I ended up here.
Having dark mode that requires me to change my operating system UI settings to activate it or install a browser extension that would somehow trick site is basically like not having it at all: https://web.dev/prefers-color-scheme/#dark-mode-but-add-an-opt-out

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants