feat: include statically analyzable dynamic imports in the eszip #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lucacasonato see here https://github.com/denoland/eszip/pull/115/files#diff-ff42aba765ab96f68cb209933964efa01404f135126af4e1cfe45d5e7c1fd0e9R936 -- a test already existed and the assertion is now flipped. |
lucacasonato
approved these changes
Feb 12, 2023
Closed
andreubotella
added a commit
to andreubotella/deno
that referenced
this pull request
Mar 5, 2023
denoland/eszip#115 added support for statically-analyzed dynamic imports in eszip, which made `deno compile` support dynamic imports starting from denoland#17858. This PR adds a test for it.
dsherret
pushed a commit
to denoland/deno
that referenced
this pull request
Mar 5, 2023
denoland/eszip#115 added support for statically-analyzed dynamic imports in eszip, which made `deno compile` support dynamic imports starting from #17858. This PR adds a test for it. ---- This test is adapted from PR #17663. Closes #17908
kt3k
pushed a commit
to denoland/deno
that referenced
this pull request
Mar 10, 2023
denoland/eszip#115 added support for statically-analyzed dynamic imports in eszip, which made `deno compile` support dynamic imports starting from #17858. This PR adds a test for it. ---- This test is adapted from PR #17663. Closes #17908
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure why this was disallowed. This allows people to run
deno compilewith statically analyzable dynamic imports.