Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSP nonce issue? #2376

Closed
adamgreg opened this issue Mar 21, 2024 · 0 comments · Fixed by #2377
Closed

CSP nonce issue? #2376

adamgreg opened this issue Mar 21, 2024 · 0 comments · Fixed by #2377

Comments

@adamgreg
Copy link
Contributor

Hi @marvinhagemeister,

I just saw #2323 , and I'm not sure it's right for the case where CSP is enabled.

A couple of lines above, where the nonce variable is created, it is missing the closing quote. Previously this was then provided within the bodyHtml string itself, but now it doesn't look like it will be.

const nonce = renderState.csp ? ` nonce="${renderState.getNonce()}` : "";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant