feat: twind plugin #513
Merged
feat: twind plugin #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacasonato
force-pushed
the
plugins_twind
branch
from
13713bf
to
b937804
Compare
lucacasonato
force-pushed
the
plugins_twind
branch
from
b937804
to
d3107fe
Compare
lucacasonato
force-pushed
the
plugins_twind
branch
from
d3107fe
to
89574ed
Compare
lucacasonato
force-pushed
the
plugins_twind
branch
from
89574ed
to
2f882bc
Compare
lucacasonato
force-pushed
the
plugins_twind
branch
from
2f882bc
to
7f87edd
Compare
|
That's great. Question: how would one use twind's shim? I noticed in the other PR you now use the result of the plugin rendering, which today is not possible (so shorthand expansions don't work for me now). Would the call to shim go in reference for how I'm using it in main right now: https://github.com/deco-cx/live/blob/main/src/main.ts#L28 |
lucacasonato
force-pushed
the
plugins_twind
branch
from
7f87edd
to
a57e81e
Compare
lucacasonato
force-pushed
the
plugins_twind
branch
from
a57e81e
to
61b8bb2
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This adds a first-party twind plugin to use twind for styling.
lucacasonato
force-pushed
the
plugins_twind
branch
from
61b8bb2
to
02a9e84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a first party plugin for
twindintegration.It also switches over
www/to us this new plugin.