Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont panic on /:foo. #26

Merged
merged 1 commit into from
Jan 17, 2022
Merged

fix: dont panic on /:foo. #26

merged 1 commit into from
Jan 17, 2022

Conversation

crowlKats
Copy link
Member

No description provided.

Copy link

@AaronO AaronO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a quickfix

@crowlKats crowlKats merged commit 9163062 into denoland:main Jan 17, 2022
@crowlKats crowlKats deleted the panic_fix branch January 17, 2022 12:55
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should really have a test...

@crowlKats
Copy link
Member Author

@ry this is not a proper fix, this is still incorrect behaviour, however this at least doesnt make us panic. This is probably an issue with the spec, so I am waiting for a fix there, and that most likely will cause wpts to be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants