Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracking: improve web performance and practices #268

Closed
Tracked by #60
iuioiua opened this issue Jun 19, 2023 · 6 comments
Closed
Tracked by #60

tracking: improve web performance and practices #268

iuioiua opened this issue Jun 19, 2023 · 6 comments
Labels

Comments

@iuioiua
Copy link
Collaborator

iuioiua commented Jun 19, 2023

https://saaskit.deno.dev/ should have the best possible score on https://pagespeed.web.dev/

This is partly dependent on #260.

@iuioiua iuioiua mentioned this issue Jun 19, 2023
30 tasks
@iuioiua iuioiua added the good first issue Good for newcomers label Jun 19, 2023
@brunocorrea23
Copy link
Contributor

This is the current lighthouse score https://saaskit.deno.dev/.

Screenshot 2023-06-21 at 21 57 44 Screenshot 2023-06-21 at 21 57 52

The only score that is not 100 is the SEO score for mobile. This happens because of the size of tap area for some of the elements. Not sure if there is any way to solve this without changing the design of the page (spacing the elements). Also, not sure if we want to do it.

Screenshot 2023-06-21 at 21 58 57

@iuioiua
Copy link
Collaborator Author

iuioiua commented Jun 22, 2023

I'm happy to increase these items' margins and possibly font size.

@iuioiua iuioiua added the v1 label Jul 18, 2023
iuioiua pushed a commit that referenced this issue Jul 20, 2023
This will bring the "Best Practices" score from 92 to 100. #268 

<img width="753" alt="Screenshot 2023-07-19 at 21 01 16"
src="https://github.com/denoland/saaskit/assets/8139585/aee1d398-3409-46da-a093-154af17ceb2a">
@brunocorrea23
Copy link
Contributor

@iuioiua , just checking with you.. are you feeling that the app is slow?
On my local machine it is super fast, but on https://hunt.deno.land/ it is taking longer to respond.

lighthouse doesn't seem to be complaining about it, as the performance score is still high, but:

it is taking 1s for server response.
Screenshot 2023-07-26 at 23 02 44

there seems to be opportunities on improving server response time
Screenshot 2023-07-26 at 23 03 33

TTFB is also not ideal. neither on mobile nor on desktop.
Screenshot 2023-07-26 at 23 04 12
Screenshot 2023-07-26 at 23 04 43

Should this be the result we are getting? Are you experiencing something similar?

@iuioiua
Copy link
Collaborator Author

iuioiua commented Jul 27, 2023

Yeah, I'm also noticing slowness. I suspect the sub-optimal DB logic to be the cause. Perhaps, fixing #400 is a step in the right direction. Also, ensuring that eventual consistency is being used where reasonable to do so.

@iuioiua
Copy link
Collaborator Author

iuioiua commented Sep 1, 2023

I'd be happy to hear any ideas on how performance can be improved across the site.

@iuioiua iuioiua changed the title todo: improve web performance and practices tracking: improve web performance and practices Sep 1, 2023
@iuioiua iuioiua removed the good first issue Good for newcomers label Sep 1, 2023
@iuioiua iuioiua pinned this issue Sep 1, 2023
@iuioiua
Copy link
Collaborator Author

iuioiua commented Sep 8, 2023

@iuioiua iuioiua closed this as completed Sep 8, 2023
@iuioiua iuioiua unpinned this issue Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants