Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.1.4 #57

Merged
merged 2 commits into from
Jan 29, 2024
Merged

1.1.4 #57

merged 2 commits into from
Jan 29, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jan 28, 2024

This release includes the upgrade of Node.js #56

I tested the current main HEAD in my project (kt3k/license-checker#35) just in case and it seemed working.

@LitoMore LitoMore mentioned this pull request Jan 28, 2024
Copy link

@LitoMore LitoMore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kt3k You may need to run npm i again to update the version number in lockfiles.

It is related to #58.

Feel free to close my PR if you want to update the version number in this PR.

@kt3k
Copy link
Member Author

kt3k commented Jan 28, 2024

@LitoMore Thanks. Updated the lockfile.

@uncenter
Copy link

uncenter commented Jan 28, 2024

Wouldn't this be a breaking change? So v2.0.0 instead of v1.1.4? Seems like most other actions consider Node.js upgrades as breaking, from what I've seen.

@LitoMore
Copy link

LitoMore commented Jan 28, 2024

Wouldn't this be a breaking change? So v2.0.0 instead of v1.1.4? Seems like most other actions consider Node.js upgrades as breaking, from what I've seen. @uncenter

Nope. setup-deno users can't use its Node.js runtime to run their scripts. So this is not breaking change.

In the meantime, we can even add more changes, like refactoring the script with ESM. 🚀

@uncenter
Copy link

Ah, true! I forgot this was a Deno repository for a second. 🤦

@kt3k kt3k merged commit 041b854 into main Jan 29, 2024
15 checks passed
@kt3k kt3k deleted the release-1-1-4 branch January 29, 2024 04:20
@kt3k
Copy link
Member Author

kt3k commented Jan 29, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants