Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiple entrypoint doesn't make sense for regexp, and jsonc #4802

Closed
kt3k opened this issue May 21, 2024 · 2 comments
Closed

multiple entrypoint doesn't make sense for regexp, and jsonc #4802

kt3k opened this issue May 21, 2024 · 2 comments
Assignees
@iuioiua

Comments

@kt3k
Copy link
Member

kt3k commented May 21, 2024 •
edited
Loading

These 3 2 packages only have single API, but have multiple entrypoint . and <API_name>. Having 2 entrypoint doesn't make much sense to them.
@iuioiua
Copy link
Contributor

iuioiua commented May 21, 2024

I believe that's for the likely event that APIs are added to these packages—we don't need to factor out the existing APIs into separate files, as they're already there. However, I see your point, too.

@kt3k kt3k mentioned this issue May 21, 2024
Merged
@kt3k kt3k changed the title multiple entrypoint doesn't make sense for html, regexp, and jsonp multiple entrypoint doesn't make sense for ~~html~~, regexp, and jsonp May 22, 2024
@kt3k kt3k changed the title multiple entrypoint doesn't make sense for ~~html~~, regexp, and jsonp multiple entrypoint doesn't make sense for html, regexp, and jsonp May 22, 2024
@kt3k kt3k changed the title multiple entrypoint doesn't make sense for html, regexp, and jsonp multiple entrypoint doesn't make sense for html, regexp, and jsonc May 22, 2024
@kt3k kt3k changed the title multiple entrypoint doesn't make sense for html, regexp, and jsonc multiple entrypoint doesn't make sense for regexp, and jsonc May 22, 2024
@iuioiua iuioiua self-assigned this May 22, 2024
This was referenced May 22, 2024
Closed
Closed
@kt3k
Copy link
Member Author

kt3k commented May 23, 2024

We decided to keep the current structure as is. This structure makes the future contribution easier.

@kt3k kt3k closed this as not planned Won't fix, can't repro, duplicate, stale May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iuioiua iuioiua

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kt3k @iuioiua