refactor: add back collections/mod.ts with a warning #2346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ry
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds back collections/mod.ts that was removed in #2321 , but adds it back with a warning. This will allow people to use collecitons/mod.ts in non-production scenarios for quick hacking and then convert their code to use the specific imports before deployment to make the module graph lean (see #2321 (comment) for more rationale about why we should have a mod.ts).
Overall, my preference would be to not even have a warning here and instead just document to not use it when publishing modules, but it was discussed during the design meeting that this would be a good compromise to try to get people away from using mod.ts when distributing or deploying modules, but still be able to use it in quick scripts.