Renaming named imports mutates remote modules

[scarf005]

Describe the bug

renaming named imports for remote modules modifies remote modules when it musn't.

To Reproduce

import { SEPARATOR } from "https://deno.land/std@0.216.0/path/constants.ts"

1. use deno's stdlib
2. rename named imports (e.g sep)

import { SEPARATOR as sep } from "https://deno.land/std@0.216.0/path/constants.ts"

expected: imports are renamed correctly with as

import { sep } from "https://deno.land/std@0.216.0/path/constants.ts"

actual: the remote file itself is modified

Expected behavior

renames must not mutate remote Remote modules cache ($DENO_DIR/deps).

Screenshots

2024-02-16.4.04.42.mov

Versions

vscode: 1.86.2 deno: 1.40.5 extension: v3.33.3

[nayeemrmn]

The 'Rename Symbol' functionality can't be used to create aliases, this is implemented in typescript Hmm, the typescript server creates as aliases when it's an import from an npm dependency. But that doesn't happen for remote deps...

As a stopgap we should rename only the file URLs and output a warning.