Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lsp): don't apply renames to remote modules #22765

Merged
merged 1 commit into from Mar 7, 2024
Merged

fix(lsp): don't apply renames to remote modules #22765

merged 1 commit into from Mar 7, 2024

Conversation

nayeemrmn
Copy link
Collaborator

@nayeemrmn nayeemrmn requested a review from dsherret March 7, 2024 07:16
dsherret
dsherret approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nayeemrmn nayeemrmn merged commit 8df4788 into denoland:main Mar 7, 2024
17 checks passed
@nayeemrmn nayeemrmn deleted the lsp-rename-symbol-file-scheme-edits-only branch March 8, 2024 01:23
littledivy pushed a commit that referenced this pull request Mar 8, 2024
@nayeemrmn @littledivy
fix(lsp): don't apply renames to remote modules (#22765)
94cf92a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Renaming named imports mutates remote modules
2 participants
@nayeemrmn @dsherret