Fix CI errors #602
Merged
Fix CI errors #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamiroh
commented
Sep 10, 2023
| "parser": "@typescript-eslint/parser" | ||
| }, | ||
| "rules": { | ||
| "no-undef": "off" // TODO: remove this line |
There was a problem hiding this comment.
Here I temporarily suppressing the no-undef errors, which currently occurs for global objects such as window, app and so on. I can't solve this problem right now, so this is a temporary work around.
tamiroh
commented
Sep 10, 2023
Merged
Vinzent03
requested changes
Sep 11, 2023
Co-authored-by: Vinzent <vinzentwitte@gmail.com>
|
Thanks for the fixes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix the CI errors, I mainly updated the svelte config in
.eslintrc.See comments for other fixes and additional information.