Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make sure PyCFunction_NewEx arguments live long enough #60

Merged
merged 1 commit into from
Dec 10, 2023
Merged

fix: make sure PyCFunction_NewEx arguments live long enough #60

merged 1 commit into from
Dec 10, 2023

Conversation

sigmaSd
Copy link
Contributor

@sigmaSd sigmaSd commented Dec 9, 2023

fix #55

aapoalas
aapoalas approved these changes Dec 9, 2023
View reviewed changes
Copy link

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

eliassjogreen
eliassjogreen approved these changes Dec 10, 2023
View reviewed changes
Copy link
Member

@eliassjogreen eliassjogreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@eliassjogreen eliassjogreen merged commit 8bd3556 into denosaurs:main Dec 10, 2023
5 checks passed
@sigmaSd
Copy link
Contributor Author

sigmaSd commented Dec 11, 2023

Thanks as well, would be great if you issue a new point release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliassjogreen eliassjogreen eliassjogreen approved these changes

@aapoalas aapoalas aapoalas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: 'builtin_function_or_method' object does not support vectorcall
3 participants
@sigmaSd @eliassjogreen @aapoalas