Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: permission error on latest deno #124

Merged
merged 1 commit into from Jan 31, 2021
Merged

fix: permission error on latest deno #124

merged 1 commit into from Jan 31, 2021

Conversation

freshfish70
Copy link
Contributor

Fixes #123

  • Tested on Deno 1.7.0
  • Breaking change for versions bellow 1.7.0

Tested on 1.6.3, 1.6.0, 1.5.0 - Not able to start with dep upgrade, gets the reverse error of HOST not exist on NetPermission

error: TS2339 [ERROR]: Property 'host' does not exist on type 'NetPermissionDescriptor'.
              return pd.host
                        ~~~~
    at https://deno.land/std@0.84.0/permissions/mod.ts:17:25

TS2339 [ERROR]: Property 'host' does not exist on type 'NetPermissionDescriptor'.
                ? `--allow-${pd.name}=${pd.host}`
                                           ~~~~
    at https://deno.land/std@0.84.0/permissions/mod.ts:18:44

@fangmarks
Copy link

@filipporeds could you review/merge this?

@mmintel
Copy link

mmintel commented Feb 1, 2021

great! will this be released soon?

@freshfish70 freshfish70 mentioned this pull request Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deno installation error
4 participants