Skip to content

Commit

Permalink
Fix: ruff version 0.3.0 cli breaking changes (#4732)
Browse files Browse the repository at this point in the history
This commit appends `check` to the ruff executable if the version of
specified ruff executable is `>= 0.3.0`, as ruff version `0.3.0`
deprecates `ruff <path>` in favor of `ruff check <path>`:

https://github.com/astral-sh/ruff/releases/tag/v0.3.0
  • Loading branch information
yining committed Mar 1, 2024
1 parent 24a937e commit b01c0b2
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 0 deletions.
4 changes: 4 additions & 0 deletions ale_linters/python/ruff.vim
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,10 @@ function! ale_linters#python#ruff#GetCommand(buffer, version) abort
\ ? ' run ruff'
\ : ''

" NOTE: ruff 0.3.0 deprecates `ruff <path>` in favor of `ruff check <path>`
let l:exec_args = l:exec_args
\ . (ale#semver#GTE(a:version, [0, 3, 0]) ? ' check' : '')

" NOTE: ruff version `0.0.69` supports liniting input from stdin
" NOTE: ruff version `0.1.0` deprecates `--format text`
return ale#Escape(l:executable) . l:exec_args . ' -q'
Expand Down
7 changes: 7 additions & 0 deletions test/linter/test_ruff.vader
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,13 @@ Execute(ruff should run with the stdin in new enough versions):
AssertLinter 'ruff', b:command_head . b:command_tail[:-3] . ' -'
" AssertLinter 'ruff', b:command_head . b:command_tail[:-3] . '--format json-lines -'

Execute(ruff should run with the check subcmd in versions >= 0.3.0):
GivenCommandOutput ['ruff 0.3.0']

AssertLinterCwd expand('%:p:h')
let b:cmd_head = ale#Escape('ruff') . ' check -q'
AssertLinter 'ruff', b:cmd_head . ' --output-format json-lines --stdin-filename %s -'

Execute(The option for disabling changing directories should work):
let g:ale_python_ruff_change_directory = 0

Expand Down

0 comments on commit b01c0b2

Please sign in to comment.